URL::base() URL::site() URL.php

[Andretti]

The method URL::base() is processing of value on each call. Can be better to cache it by sample Lasy Load pattern?

Example:

public static function base($protocol = NULL, $index = FALSE)
{
   // Beforehand to add property "private static $base_url";
   if (Valid::not_empty(self::$base_url))
   {
      return self::$base_url;
   }

   // Start with the configured base URL
   $base_url = Kohana::$base_url;

   if ($protocol === TRUE)
   {
      // Use the initial request to get the protocol
      $protocol = Request::$initial;
   }
...

[shadowhand]

What performance difference do you think this would make in the real world? How would you handle differences in the protocol or index parameter?

[Andretti]

When I made migrating from 3.3.3.1 to 3.3.4 it seemed to me that the URL::base() can be improved. But now I see my proposition is incorrect. I think this topic can be removed.

[johny64]

you can win 0.000000000000000000001s, my congratulations